Skip to content

Conversation

ravibitgo
Copy link
Contributor

@ravibitgo ravibitgo commented Oct 3, 2025

Ticket: COIN-5871

@ravibitgo ravibitgo force-pushed the COIN-5838 branch 9 times, most recently from c2e5729 to f0cd4f6 Compare October 7, 2025 16:35
@ravibitgo ravibitgo changed the base branch from COIN-5838 to master October 8, 2025 09:53
@ravibitgo ravibitgo force-pushed the COIN-5871 branch 8 times, most recently from beeed3a to b6a59d5 Compare October 8, 2025 12:04
@ravibitgo ravibitgo marked this pull request as ready for review October 8, 2025 12:34
@ravibitgo ravibitgo requested review from a team as code owners October 8, 2025 12:34
@ravibitgo ravibitgo changed the title feat(sdk-coin-canton): added transaction class feat(sdk-coin-canton): added transaction class and local parser for prepared transaction data Oct 8, 2025
Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baltiyal baltiyal requested a review from Copilot October 8, 2025 15:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds transaction classes and local parser functionality for Canton prepared transaction data. It enables the SDK to parse raw Canton transaction data and extract key information like sender, receiver, and amounts from protobuf-encoded prepared transactions.

  • Adds a new Transaction class for handling Canton prepared transaction data with parsing capabilities
  • Implements a utils method to parse raw Canton transaction data and extract transaction details
  • Adds a separate WalletInitialization Transaction class for wallet initialization scenarios

Reviewed Changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tsconfig.json Includes resources directory for protobuf files
utils.ts Adds parseRawCantonTransactionData method for transaction parsing
transaction.ts Implements Transaction class with prepared transaction handling
iface.ts Defines interfaces for transaction data and protobuf structures
package.json Adds protobuf-ts/runtime dependency and updates build scripts
resources/ Contains protobuf message type definitions for Canton transaction parsing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@baltiyal baltiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good

Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@at31416 at31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravibitgo ravibitgo merged commit 8543cd6 into master Oct 9, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants